From 0c615f8dadb4389048d574abd1515861d3f8403f Mon Sep 17 00:00:00 2001 From: Andrew Cooper Date: Wed, 18 Jun 2014 18:44:44 +0100 Subject: [PATCH] tools/libxc: Fix missing break in xc_domain_bind_pt_irq() c/s 568da4f8 "pt-irq fixes and improvements" accidentally forgot a break when refactoring xc_domain_bind_pt_irq() which results in bind->u.pci.bus being clobbered by isa_irq for PCI and MSI_TRANSLATE interrupts. Coverity-ID: 1223210 Signed-off-by: Andrew Cooper CC: Jan Beulich CC: Ian Campbell CC: Ian Jackson --- tools/libxc/xc_domain.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/libxc/xc_domain.c b/tools/libxc/xc_domain.c index ef470a5ba1..d5d6d12f74 100644 --- a/tools/libxc/xc_domain.c +++ b/tools/libxc/xc_domain.c @@ -1711,6 +1711,7 @@ int xc_domain_bind_pt_irq( bind->u.pci.bus = bus; bind->u.pci.device = device; bind->u.pci.intx = intx; + break; case PT_IRQ_TYPE_ISA: bind->u.isa.isa_irq = isa_irq; break; -- 2.30.2